Jump to content
Strawberry Orange Banana Lime Leaf Slate Sky Blueberry Grape Watermelon Chocolate Marble
Strawberry Orange Banana Lime Leaf Slate Sky Blueberry Grape Watermelon Chocolate Marble

MSFN is made available via donations, subscriptions and advertising revenue. The use of ad-blocking software hurts the site. Please disable ad-blocking software or set an exception for MSFN. Alternatively, register and become a site sponsor/subscriber and ads will be disabled automatically. 


roytam1

My browser builds (part 2)

Recommended Posts

On 11/16/2019 at 7:27 AM, roytam1 said:

- Issue #1259 - Part 1. Remove Adobe Primetime support from tree (0fb5f7a15)
- Issue #1259 - Part 2. Remove Adobe Primetime localization strings (c74e21f18)
- Issue #1259 - Part 3. Remove Adobe EME as a GMP source (0aa805d1f)
- Issue #1259 - Part 4. Remove Adobe EME from GMPUtils (a6441a2a8)
- Issue #1259 - Part 5. Remove migration path for Adobe GMP storage (484200b01)
- Issue #1259 - Part 6. Remobe Adobe EME from Basilisk frontend (400f0e2df)
- Issue #1259 - Part 7. Update tests for Adobe EME removal (c43b770a0)

Will this have some consequence on video playing? I checked my profile and found 3 folders:

gmp\WINNT_x86-msvc, empty;

gmp-eme-adobe, empty;

gmp-gmpopenh264\1.6, gmpopenh264.info, gmpopenh264.dll

Currently I have no problem playing videos I encounter.

Share this post


Link to post
Share on other sites

3 hours ago, VistaLover said:

How is that guaranteed to only touch Serpent 52's AOM (WebExtAM) but NOT NM28's AOM (TychoAM) ?

Let's get this out of the way right off: I didn't touch the functionality of either AM! All I did was revert the Bugzilla "fix" in Serpent 52, restoring version numbers to its about:addons page. I didn't (and really, can't) turn Tycho into WebEx or vice versa. Serpent will continue to support the same limited WebEx add-ons; NM still will not. Nothing has changed except that one bit of information on about:addons. This is cosmetic surgery, not brain surgery ;)

But it did take me a while to figure out how UXP separates the two browsers. The UXP repo is a bit of a mess, since it has to support PM/NM, Serpent/Basilisk, and XULRunner (used by KM).

Turns out under folder toolkit/mozapps there are two subfolders, extensions and webextensions. Each of those folders has a subfolder named "content," which in turn has a file named "extensions.xml." Under "extensions," that file matches the "before" code in Bugzilla, but under "webextensions," it matches the "after" code (the version number has been moved to a tooltip). Clearly, Serpent uses the code in "webextensions," so I just added back the code that the Bugzilla "fix" stripped out, essentially reverting it. This is the same thing the Waterfox folks did to restore version numbers to that browser (yes, I checked that commit too), except in the Mozilla repo there is only an "extensions" folder, not a "webextensions" one.

Finally, I also added the one-line change from Waterfox that lets you turn the version numbers back off if you don't like them. I did that in both "webextensions" and "extensions," so that's the only change that will affect NM.

3 hours ago, VistaLover said:

NM does not need that pref, OR the functionality of that PR

Well, I'm a stickler for consistency, and implementing that pref required only a one-line change, so I implemented it in both browsers. The only thing the new pref does is suppress version numbers if it's created in about:config and set to false. IOW, NM 28 will continue to work exactly as it does now, unless you decide you don't want it to!

3 hours ago, VistaLover said:

Also,

Quote

This is a more complex change than usual; please review my work for errors before merging!

Was that actually carefully examined?

Well, I was as careful as I could manage to be in merging the code in. I'm confident I got the one-line change to check the new pref (in both NM and Serpent) right, but there were quite a lot of code that needed to be put back into Serpent's extensions.xml to revert the Bugzilla "fix." And I've done enough coding to know how easy it is to slip up and break something no matter how careful you are.

Unfortunately, I don't have a system capable of building these browsers myself. So I wrote that comment in the hope that @roytam1 will do a test build of both browsers, and revert my changes if there are any problems.

3 hours ago, VistaLover said:

I'm a firm believer in the adage: "Don't fix it if it ain't broken!" and, as of this writing, NOTHING IS BROKEN (yet) ...

I don't see it that way. IMO something is broken in FF 40+, and in Serpent; it's just that, as a user of the CTR add-on, I never realized it because the add-on patches the bug! MCP and Waterfox both seem to agree with that assessment, as they both implemented the same fix. Unfortunately, in MCP's case, it was bundled with a much larger "fix" - removing all WE support - that actually did violate your adage, so the "cure" was worse than the disease. (Waterfox fixed it correctly, but of course it requires 64-bit Win 7; otherwise we'd all be using it and @roytam1 would have a lot less work to do every week!)

As for CTR, I think you're blowing the Tycho vs. WebEx thing way out of proportion. Like my own changes, CTR is cosmetic surgery, not brain surgery. Neither of us care what's going on deep inside the browser; we're both just changing how things look to the user. The engine underneath doesn't really matter, because it's not interfacing at that level. If it did, how could you expect CTR to work with browsers as different as Basilisk (Tycho AM) and Waterfox (modified WebEx AM) and yet not work with Serpent 52 (WebEx AM with UI modified as in Waterfox)?

5 hours ago, VistaLover said:

If, despite all the above, one insists on installing CTR v1.7.8.2019 in St52, then, as posted, to get the AVN feature back (present in CTR 1.7.8) just co-install either of

Version Number in Add-ons Manager 1.10 (by magicp)
caa:addon/addonvernumber/versions?page=1#version-1.10

I think this is your best point. As it happens, I did look for add-ons besides CTR that would put the version numbers back. After all, not everyone wants to install CTR just to fix that one issue. I didn't have much luck, but then, I didn't look very hard, since it seemed fairly simple and more sensible to just fix the problem at its source.

At the end of the day, though, this is the same argument we've seen over other features that Mozilla or MCP have removed (container tabs come to mind): is it better to have the feature in the browser itself, or as an add-on of some sort? Usually, we've come down on the side of leaving the feature in the browser, and that's what I'm trying to do here.

  • Like 1

Share this post


Link to post
Share on other sites
3 minutes ago, luweitest said:

Will this have some consequence on video playing? I checked my profile and found 3 folders:

gmp\WINNT_x86-msvc, empty;

gmp-eme-adobe, empty;

gmp-gmpopenh264\1.6, gmpopenh264.info, gmpopenh264.dll

Currently I have no problem playing videos I encounter.

I'm not sure how I feel about removing Primetime support.

On one hand, @roytam1 already builds in support for playing .mp4 files, so you would think Primetime isn't really needed any more.

But OTOH, there have been reports of badly distorted audio when playing some .mp4 videos. Disabling the built-in support and installing Primetime fixes this issue, but that won't be possible with Primetime support removed.

The distorted audio issue seems to be rare, but it does still seem to exist. Has anyone encountered it lately? If so, could you post a link to a video exhibiting the problem?

Share this post


Link to post
Share on other sites
2 hours ago, Mathwiz said:

I'm not sure how I feel about removing Primetime support.

I know I won't. Then again, I even keep a Real Player plugin in my main rig, set to "ask to activate", although I actually cannot remember anymore the last time it was useful, if ever, since this rig's XP install time (early 2007).

  • Upvote 1

Share this post


Link to post
Share on other sites
4 hours ago, luweitest said:

Will this have some consequence on video playing? I checked my profile and found 3 folders:

gmp\WINNT_x86-msvc, empty;

gmp-eme-adobe, empty;

gmp-gmpopenh264\1.6, gmpopenh264.info, gmpopenh264.dll

Currently I have no problem playing videos I encounter.

can't tell as they're reverted in my tree.

Share this post


Link to post
Share on other sites
4 hours ago, Mathwiz said:

The UXP repo is a bit of a mess, since it has to support PM/NM, Serpent/Basilisk, and XULRunner (used by KM).

UXP XULRunner is not used by K-Meleon(I hope I can make changes to make KM use UXP, but for now KM uses Tycho.)

  • Like 1

Share this post


Link to post
Share on other sites
5 hours ago, Mathwiz said:

The distorted audio issue seems to be rare, but it does still seem to exist. Has anyone encountered it lately? If so, could you post a link to a video exhibiting the problem?

Yes on occasion with UXP, with the most recent being Fox Video.

https://video.foxnews.com/playlist/featured-latest-news/

The problem for me is when the user agent is IE11 but changing it for that specific site resolves it. With Twitter I set it to the latest firefox ua and with Fox Video specifically I had to set static.foxnews.com.  

Share this post


Link to post
Share on other sites

@Matzwiz
> Unfortunately, I don't have a system capable of building these browsers myself.
> So I wrote that comment in the hope that @roytam1 will do a test build of both browsers,
> and revert my changes if there are any problems.

If it's only normal xml/html/js files, not CPP, you can most likely find and exchange those inside omni.ja
In K-Meleon works fine, just not sure if those other/newer browsers allow changing omni.ja too or if it breaks some signature or whatever.

  • Like 1

Share this post


Link to post
Share on other sites

Both privacy.resistFingerprinting and canvas.poisondata are not enough to get a good browser setting for privacy.


-----
Totally agree. We could have a whole separate thread on setting up browsers for privacy. The topic goes far beyond those two prefs.
Remember, this topic came up because the UOC Patch sets privacy.resistFingerprinting for performance reasons, but it comes at the cost of compatibility with Flash.


Yeah that's the crux, max privacy and max features are mutually exclusive. One just cannot block at the same time all sorts of privacy related functions and still have all features working, if those require some of those functions. It's a dilemma.
We understand this here but unfortunately, when looking around the web, most users still don't have the slightest clue! They keep thinking they could get a set of "flawless" privacy settings, then after adding some more magical prefs are soon disappointed to discover "bugs". They keep fiddling with new settings, only to fall into another trap shortly after. Never quite understanding it's simply not possible to block lots of stuff and still get everything working at the same time.
And of course by far the best privacy protection is to just block javascript completely (causing a few 'bugs' too as expected 8-)

Privacy settings are such a giant subject, a separate thread wouldn't be nearly enough. At least not for the endless jungle of Mozilla prefs, IIRC current browsers have over 3000 prefs already (yikes!) Makes probably a million possible combinations... many cross-influencing each other, and additionally users have different hardware and browsers, complicating things yet more... Can't imagine there's even just 1 expert left who still understands all of this with all cross-effects too.

There are already lots of projects out there trying to find at least a good compromise of permanent settings for most users, although not really possible, considering everyone has different needs too (needing stuff like facebook and gmail or not etc). But still better than nothing. Like the famous ghacks user.js, or german site privacy-handbuch.de (oh great, which now blocks old browsers too, no TLS1.2)

The only real solution for this dilemma is to toggle some settings only TEMPORARILY when needed. It keeps surprising me how few people even consider doing this. Although admittedly not quite easy, it requires some knowledge what those toggles are doing. Still it's the method that works best, and one of the reasons I absolutely love K-Meleon with my long row of toggle buttons, many self-created (mainly macros Blockeria and priv3buttons). Although I can only toggle a few prefs too, among the 3000, but as mentioned, blocking javascript (completely or partly) goes a very long way towards privacy already, and blocking 3rd party iframes etc. too.

Share this post


Link to post
Share on other sites

 

12 hours ago, roytam1 said:

can't tell as they're reverted in my tree.

Sorry I skimmed too quickly that I did not notice your reversion line!

On 11/16/2019 at 7:27 AM, roytam1 said:

My changes since my last build:

- Reverted commits related to Issue #1259

As to video playing, there is one site that do have problems, which I have filed a bugzilla https://bugzilla.mozilla.org/show_bug.cgi?id=1414792 ,but firefox devs think it's website's fault.

Edit: I rechecked the link in the bug and surprisingly find Serpent has fixed the bug! The site works now.  Thanks roytam!

Edited by luweitest

Share this post


Link to post
Share on other sites

Mathwiz wrote:

"The distorted audio issue seems to be rare, but it does still seem to exist. Has anyone encountered it lately? If so, could you post a link to a video exhibiting the problem?"

__________________________

I had these problems, the sound on Twitter videos was distorted as in slow motion.

This solution to this audio bug I've found, works here:

In about:config click New / string to create this user set new Preference name:

general.useragent.override.twitter.com

- then value in New Moon 28 is:

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:4.2) Goanna/4.0 Firefox/55.0 PaleMoon/28.6.0a1

That's the part that does the trick: "Firefox/55.0" but you can put between Firefox/38.0 to Firefox/69.0 ... or Firefox/99.0 or more...

The value in Serpent52/ Basilisk I have:

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Firefox/52.9

The value in Serpent55/ Moebius I have:

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:55.0) Gecko/20100101 Goanna/4.0 Firefox/55.0

...and set Firefox compatibility in Preferences/Advanced/General tab, or in about:config set to default true: general.useragent.compatMode.firefox

Link to test distorted Twitter video: https://twitter.com/josefkenny/status/974587426676117505

So now, the sound on Twitter videos is OK here, no more distorted audio in these browsers, solved.

Thank you!

 

  • Like 1

Share this post


Link to post
Share on other sites

how can I solve this issue on Serpent 52 ?

the sound is distorted in Gecko mode then I activate the Firefox mode to get it right.

the problem is that in some streaming sites the video miniatures are not displayed with Firefox mode activated.

I can only see the title of videos but the small video miniatures are missing. :angry:

 

screenshot.3.thumb.png.4e3ae7d63ecdd99c5ce99694a5f1e48c.png

Edited by caliber

Share this post


Link to post
Share on other sites

Caliber said:
> how can I solve this issue on Serpent 52 ?
> the sound is distorted in Gecko mode then I activate the Firefox mode to get it right.
> the problem is that in some streaming sites the video miniatures are not displayed
> with Firefox mode activated.

Solution: set a DOMAIN-specific override UA for those sites.
The "compatModes" only affect the general, default useragent if I'm not mistaken.

There's an interesting new pref in your pic: "...compatMode.AppleWebKit"
Can't find it by a quick search, is there any info somewhere what it does, and in which browser/version?


  • Like 1

Share this post


Link to post
Share on other sites
13 minutes ago, siria said:

Solution: set a DOMAIN-specific override UA for those sites.
The "compatModes" only affect the general, default useragent if I'm not mistaken.
 

it has no effect, the problem persists

Share this post


Link to post
Share on other sites

Caliber said:
> the problem is that in some streaming sites the video miniatures are not displayed
> with Firefox mode activated.

With site-UA:
> it has no effect, the problem persists

Most likely either:
- the page contains elements from other domains too, which must be tweaked too
- or you have a useragent addon installed which disabled the native UA-system, but this can easily be tested

  • Like 1

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


×
×
  • Create New...