Using SC (Service Controller) command in a batch file

[Comos]

Hi All,

Im using a little batch file for configuring a remote shell service for a specific account.The only problem is,that the password when wanted to leave as default by the batch (Admin) is somehow not set by the service and I have to do it manually then.

Here is the code:

echo Now configuring the Remote Shell Service

echo Stopping the Service
sc stop RshSvc

echo Enter the Password for Admin account or ENTER to leave it as Admin
set /p adminpwd=:
if "%adminpwd%"=="" set pwd=Admin
if %errorlevel%==0 set pwd=%adminpwd%

sc config RshSvc type= own obj= %computername%\Admin password= %pwd%

echo Starting the service
sc start RshSvc

Any idea where's the bug?

[jaclaz]

Any idea where's the bug?

Cannot say if it is a bug, but usually with this kind of batches it is better to use "negative logic".

@ECHO OFFSET Defaultpwd=Adminecho Now configuring the Remote Shell Serviceecho Stopping the Servicesc stop RshSvcecho Enter the Password for Admin account or ENTER to leave the default oneset /p adminpwd=Type password or press [ENTER] to leave the Default one.IF NOT DEFINED adminpwd SET adminpwd=%Defaultpwd%sc config RshSvc type= own obj= %computername%\Admin password= %adminpwd%echo Starting the servicesc start RshSvc

jaclaz

[Yzöwl]

What happens if you change it like this:

@echo offsetlocalecho=Now configuring the Remote Shell Serviceecho=Stopping the Servicesc stop RshSvcecho=Enter the Password for Admin account or ENTER to leave it as Adminset /p "adminpwd = "if not defined adminpwd (set adminpwd=Admin)sc config RshSvc obj= "Admin" password= "%adminpwd%"echo=Starting the servicesc start RshSvc

[HarryTri]

The %errorlevel% is of the previews "set pwd=Admin" command? Which is supposed to be the default password? Maybe the correct syntax would be "if "%adminpwd%"=="" set %adminpwd%=Admin"? I think that as it is writen if %adminpwd% is null it remains so and pwd becomes null also.

[Comos]

Thanks guys, I'll probe it !