nicolaasjan Posted February 10, 2023 Share Posted February 10, 2023 (edited) 4 hours ago, oitoevinte said: Just grabbed yt-dlp from the signature, didn't knew this was ported to XP, but it's coming with a few concerns on Virustotal https://www.virustotal.com/gui/file/2c7adccafeb7f15ff664a688f993a8ee00260da14981e19932ee6da8a938ca6d/relations A few false positives from some unknown security vendors is quite common. See issue #25. The executable on yt-dlp's GitHub is built with a custom Pyinstaller from https://github.com/yt-dlp/pyinstaller-builds and doesn't have that issue. I use the official Pyinstaller. [Edit] See also: https://stackoverflow.com/questions/69899867/python-script-distribution-on-windows-options-to-avoid-virus-false-positives. Edited February 10, 2023 by nicolaasjan 1 Link to comment Share on other sites More sharing options...
VistaLover Posted February 11, 2023 Share Posted February 11, 2023 5 hours ago, nicolaasjan said: The executable on yt-dlp's GitHub is built with a custom Pyinstaller from https://github.com/yt-dlp/pyinstaller-builds and doesn't have that issue. (...) I use the official Pyinstaller. Latest PyInstaller on PyPI is at version 5.7.0 ; yt-dlp "org" have used custom compiles of PyInstaller v 4.5.1->4.9->4.10->5.2 and are now (probably) using v5.3 ... The 32-bit wheels of those custom compiles can be seen in below branch: https://github.com/yt-dlp/Pyinstaller-Builds/tree/gh-pages/i686 Direct link for latest v5.3: https://github.com/yt-dlp/Pyinstaller-Builds/raw/gh-pages/i686/pyinstaller-5.3-py3-none-any.whl If you so wish, you yourself can switch over to this custom yt-dlp compile of PyInstaller: python -m pip uninstall pyinstaller (will uninstall v5.7.0 fetched from PyPI) python -m pip install "path-to-downloaded/pyinstaller-5.3-py3-none-any.whl" or even: python -m pip install "https://github.com/yt-dlp/Pyinstaller-Builds/raw/gh-pages/i686/pyinstaller-5.3-py3-none-any.whl" ... then build yt-dlp_x86.exe with that ... Link to comment Share on other sites More sharing options...
nicolaasjan Posted February 11, 2023 Share Posted February 11, 2023 (edited) 6 hours ago, VistaLover said: If you so wish, you yourself can switch over to this custom yt-dlp compile of PyInstaller: That's what I once did, but unfortunately it had issues here. 11124 INFO: Loading module hook 'hook-yt_dlp.py' from 'C:\\Program Files\\Python38\\lib\\site-packages\\_pyinstaller_hooks_contrib\\hooks\\stdhooks'... File "<string>", line 3 import yt-dlp ^ SyntaxError: invalid syntax See: https://github.com/yt-dlp/yt-dlp/issues/4332 Pukkandan's answer: Quote Why are you using our custom builds? They are meant only for use in our release process. Install the actual pyinstaller Edited February 11, 2023 by nicolaasjan Link to comment Share on other sites More sharing options...
oitoevinte Posted February 11, 2023 Share Posted February 11, 2023 Thanks for clearing that out. I'm familiar with false positives, it's just that phone home to an MS Azure server that tickled me. Btw, do you publish your youtube-dl fixed binares elsewhere or just in this forum? I don't see it on your Github. And Thanks for your your! Link to comment Share on other sites More sharing options...
nicolaasjan Posted February 11, 2023 Share Posted February 11, 2023 1 hour ago, oitoevinte said: Btw, do you publish your youtube-dl fixed binares elsewhere or just in this forum? I don't see it on your Github. Youtube-dl is not released (by me) on GitHub. Yt-dlp is here (forked the official repo and publish in-between builds. Then manually upload my compiled XP compatible one) : https://github.com/nicolaasjan/yt-dlp/releases Click on "Show all 19 assets" and you'll see "yt-dlp_x86_Windows-XP.zip". In the New Moon browser you need the extension "Palefill Web Technologies Polyfill" (palefill-1.26.xpi) to navigate GitHub. 3 Link to comment Share on other sites More sharing options...
nicolaasjan Posted February 11, 2023 Share Posted February 11, 2023 1 hour ago, oitoevinte said: it's just that phone home to an MS Azure server that tickled me. Maybe that's because it was analysed om a MS Windows system. Link to comment Share on other sites More sharing options...
VistaLover Posted February 11, 2023 Share Posted February 11, 2023 10 hours ago, nicolaasjan said: See: https://github.com/yt-dlp/yt-dlp/issues/4332 In that linked GH issue, you were at PyInstaller v4.10 (custom "yt-dlp" build); have you given their most-up-to-date version 5.3 (linked in my previous comment) a shot? The idea is that a custom build has a unique bootloader not shared with the rest of the EXEs compiled with the widely available PyPI edition of PyInstaller, thus raising less red flags (false detections) with (mostly) low-quality AV suites ... And, in any case, you did say in that comment that: Quote yt-dlp is just working fine however. So, you stand to lose nothing by trialing v5.3... My 2c, of course... 1 Link to comment Share on other sites More sharing options...
nicolaasjan Posted February 11, 2023 Share Posted February 11, 2023 24 minutes ago, VistaLover said: So, you stand to lose nothing by trialing v5.3... My 2c, of course... I will try tomorrow in a VM snapshot and see what happens. Stay tuned. 1 Link to comment Share on other sites More sharing options...
nicolaasjan Posted February 11, 2023 Share Posted February 11, 2023 By the way, the official yt-dlp.exe connected to 13 IP's, according to VirusTotal... 1 Link to comment Share on other sites More sharing options...
nicolaasjan Posted February 11, 2023 Share Posted February 11, 2023 41 minutes ago, nicolaasjan said: 1 hour ago, VistaLover said: So, you stand to lose nothing by trialing v5.3... My 2c, of course... I will try tomorrow in a VM snapshot and see what happens. Stay tuned. I was so curious, that I tested it now. 4 security vendors and no sandboxes flagged this file as malicious. And ugly warnings when running 'yt-dlp -v': https://0x0.st/HrT8.txt. So I'll just follow Pukkandan's advice and keep using the official PyInstaller. Link to comment Share on other sites More sharing options...
VistaLover Posted February 12, 2023 Share Posted February 12, 2023 6 hours ago, nicolaasjan said: And ugly warnings when running 'yt-dlp -v': https://0x0.st/HrT8.txt. Actually, unrelated to what we've been discussing here... The multiple [1888] WARNING: file already exists but should not: C:\DOCUME~1\nico\LOCALS~1\Temp\_MEI18882\Cryptodome\* warnings are a manifestation of a very recent bug, which I have reported here (possibly related to the new "ways" PyCryptodome[x] is imported at yt-dlp's runtime and, thus, the "new" ways the module is being packed by PyInstaller) ... Even your very own compiles are being affected by that bug: https://github.com/nicolaasjan/yt-dlp/releases/download/2023.02.09.051430/yt-dlp_x86.exe https://github.com/nicolaasjan/yt-dlp/releases/download/2023.02.11.092312/yt-dlp_x86.exe (One needs Vista SP2+ [32 and/or 64-bit] to test these). The bug may be exclusive to the GitHub Actions compiled builds, because the ones I prepare myself locally (with CPython 3.7.16), as well as your "manual" build "yt-dlp_x86_Windows-XP.zip", do not exhibit this bug ... Sometimes I wish the yt-dlp devs left the code "at peace" for awhile, in a good-working-state... "Shouldn't fix what isn't broken" comes to mind... But what do I know (except for stumbling on bugs ) ? 2 Link to comment Share on other sites More sharing options...
nicolaasjan Posted February 12, 2023 Share Posted February 12, 2023 5 hours ago, VistaLover said: The bug may be exclusive to the GitHub Actions compiled builds, because the ones I prepare myself locally (with CPython 3.7.16), as well as your "manual" build "yt-dlp_x86_Windows-XP.zip", do not exhibit this bug ... That's because my XP port is built with PyInstaller 5.7, in which the bug is fixed. See here. Quote Even your very own compiles are being affected by that bug: https://github.com/nicolaasjan/yt-dlp/releases/download/2023.02.09.051430/yt-dlp_x86.exe https://github.com/nicolaasjan/yt-dlp/releases/download/2023.02.11.092312/yt-dlp_x86.exe I only occasionally test these, to be honest... Quote Sometimes I wish the yt-dlp devs left the code "at peace" for awhile, in a good-working-state... "Shouldn't fix what isn't broken" comes to mind... Exactly what I was thinking. 1 Link to comment Share on other sites More sharing options...
nicolaasjan Posted February 28, 2023 Share Posted February 28, 2023 (edited) FYI, YouTube changed something... Downloads are now very slow. See: https://github.com/yt-dlp/yt-dlp/issues/6369 Lets hope it can be fixed. [Edit] Format 22 (mp4; 1280x720) is not affected, e.g: yt-dlp -f 22 https://www.youtube.com/watch?v=ppojLHm-Z1I [download] 100% of 103.60MiB in 00:00:08 at 11.51MiB/s Edited February 28, 2023 by nicolaasjan 3 Link to comment Share on other sites More sharing options...
nicolaasjan Posted February 28, 2023 Share Posted February 28, 2023 Pushed a release (only yt-dlp) with the latest fixes from upstream. Download speed should be back to normal now. 2 Link to comment Share on other sites More sharing options...
nicolaasjan Posted February 28, 2023 Share Posted February 28, 2023 (edited) This is now added to the Readme: Quote yt-dlp supports only Python 3.7+ and may remove support for more versions as they become EOL; while youtube-dl still supports Python 2.6+ and 3.2+ This version is built with Python 3.8, EOL: 2024-10 Edited February 28, 2023 by nicolaasjan 2 Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now