Changes I Made - Improvements

[guest123]

I found the FileExists function doesn't like the quotes around the filename so I moved the code which adds the quotes to after the FileExists check within installer.js e.g.:

if (cmdLine.indexOf(" ") != -1 && cmdLine.substr(0,1) != '"')

cmdLine='"'+cmdLine+'"';

if (!FileExists(cmdLine))

{

programs.fail=true;

cmdName=(cmdName=='regb') ? 'Reg Before' : (cmdName=='rega') ? 'Reg After' : cmdName;

WriteLogLine(cmdName+' '+result+' (returned code '+ReturnCode+'): RegEdit /S "'+cmdLine+'"');

return;

}

became:

if (!FileExists(cmdLine))

{

programs.fail=true;

cmdName=(cmdName=='regb') ? 'Reg Before' : (cmdName=='rega') ? 'Reg After' : cmdName;

WriteLogLine(cmdName+' '+result+' (returned code '+ReturnCode+'): RegEdit /S "'+cmdLine+'"');

return;

}

if (cmdLine.indexOf(" ") != -1 && cmdLine.substr(0,1) != '"')

cmdLine='"'+cmdLine+'"';

I also made the following change in core.js to remove the security prompt that occurs everytime sleep.exe is called:

sleepCmd=wpipath+"Tools\\Sleep.exe";

became:

sleepCmd="cmd /c "+wpipath+"Tools\\Sleep.exe";

[mritter]

Looked at your code some more. That is an older version of the code. Between Dje and I we have worked out pretty much all the issues with quotes and args. Attached is the latest official version. Just replace your curent one with this one.

[almulder]

Ok, but the installer will not work now it says "programs" undefined now. and before that the execute before and after will not work.

any thoughts?

[mritter]

Download this archive. Between Dje and myself we have made several updates to the installer and the program variable got moved to globals.js. Check out this link for a more complete update:

http://www.msfn.org/board/index.php?showtopic=75447&st=75