[BUG+FIX] A javascript error is shown before reboots

[Francesco]

Cause

A wrong function call in installer.js causes the error

Solution

In installer.js replace

pause(3600,0);				// Give some time for {reboot} to take affect

with

Pause(3600,0);				// Give some time for {reboot} to take affect

[Kelsenellenelvian]

I belive you got this one wrong I find alot os pausenew bot no pause with the 3600,0 denominator

[Francesco]

I belive you got this one wrong I find alot os pausenew bot no pause with the 3600,0 denominator

I re-downloaded the WPI8.2.2 code and in installer.js there are three instances of that line:

			if (CheckPendingFileRenameOperations())
			{
				WriteRegKey("HKEY_CURRENT_USER\\Software\\WPI\\CurrentPFRO",i,"REG_DWORD");

				CheckAutoLogonCount();

				cmdLine='"'+sysdir+'\\shutdown.exe" -r -f -t 10 -c "'+getText(ComputerWillRestartPFRO)+'"';
				RunCmd(cmdLine,false,true);
				pause(3600,0);				// Give some time for {reboot} to take affect
			}

			if (programs[i].repeatcommand=="yes")
			{
				var RepeatCommand=RegKeyValue("HKEY_CURRENT_USER\\Software\\WPI\\LastExec");
				WriteRegKey("HKEY_CURRENT_USER\\Software\\WPI\\LastExec",RepeatCommand-1,"REG_DWORD");      //Save current position for reboots

				FailNum++;
				WriteRegKey("HKEY_CURRENT_USER\\Software\\WPI\\FailNum",FailNum,"REG_DWORD");
			}

			cmdLine='"'+sysdir+'\\shutdown.exe" -r -f -t 5 -c "'+getText(ComputerWillRestart)+'"';
			RunCmd(cmdLine,false,true);
			pause(3600,0);				// Give some time for {reboot} to take affect

	if (IsReboot)
	{
		CheckAutoLogonCount();

		box='';
		box+='<table border="0" width="100%" cellpadding="0" cellspacing="0">';
		box+='<tr><td class="InstallText" nowrap>';
		box+='<img src="../Common/imgs/spacer.gif" border="0" width="20" height="1">';
		box+=getText(lblCommand)+' '+cmdNum+'...';
		box+='</td><td width="100%">';
		if (!ShowInstallerImages)
			box+='<div id="div'+item+'_'+cmdNum+'_'+FailNum+'" class="InstallSuccess" style="position:relative; top:0px; left:0px; width:100%;">'+getText(txtInstallSuccess)+'</div>';
		else
			box+='<div id="div'+item+'_'+cmdNum+'_'+FailNum+'" class="InstallSuccess" style="position:relative; top:0px; left:0px; width:100%;"><img src="../Themes/'+Theme+'/Install_Success.png" border="0" width="16" height="16"></div>';
		box+='</td></tr></table>';
		AddHistoryEntry(box+"\n");

		pause(3600,0);			// Give some time for {reboot} to take affect
	}

Maybe the spacing was changed when I posted the message so an exact search of the line doesn't work: try looking only for pause(3600,0);

[Kelsenellenelvian]

done

[jaclaz]

done

OT, and just to be picky, I've often seen {reboot} taking effect, but rarely affect.

jaclaz

[Kelsenellenelvian]

LOL