Arctic-Fox for Windows builds

[roytam1]

actually it doesn't go far. getting C4519 error when merging https://github.com/roytam1/palemoon27/commit/f66a5071eb4549e79d6c298c13d42ff23284701b#diff-c2c2526080397c87a9a8f9b3760d146fa46cee109961492737bd62f49ca1d5b6R35

[Nicholas McAnespy]

1 hour ago, roytam1 said:

actually it doesn't go far. getting C4519 error when merging https://github.com/roytam1/palemoon27/commit/f66a5071eb4549e79d6c298c13d42ff23284701b#diff-c2c2526080397c87a9a8f9b3760d146fa46cee109961492737bd62f49ca1d5b6R35

If you haven't fixed it yet, do you want to upload a zip file containing the source code you are/were working on?

[roytam1]

1 hour ago, Nicholas McAnespy said:

If you haven't fixed it yet, do you want to upload a zip file containing the source code you are/were working on?

no idea how to fix it, tree is pushed to github. https://github.com/roytam1/palemoon27/commits/pm27100-vc2010

[Nicholas McAnespy]

22 hours ago, roytam1 said:

no idea how to fix it, tree is pushed to github. https://github.com/roytam1/palemoon27/commits/pm27100-vc2010

I was hoping I would get the broken source code with bug 1134425 already applied, so I could see what removing the characters = CanGC from template <typename T, AllowGC allowGC = CanGC> would do. 

Edited July 9 by Nicholas McAnespy

[roytam1]

6 hours ago, Nicholas McAnespy said:

I was hoping I would get the broken source code with bug 1134425 already applied, so I could see what removing the characters = CanGC from template <typename T, AllowGC allowGC = CanGC> would do. 

that means you no longer providing a default allowGC option. related bugzilla entry: https://bugzilla.mozilla.org/show_bug.cgi?id=1134425

EDIT: maybe it can be done using overloads, but not tested: https://stackoverflow.com/a/2447927/145278

EDIT2: and yeah that works, so I can continue merging.

Edited July 9 by roytam1

[roytam1]

now there is a problem when merging 0b23a2783d03b3f5fe404544db3043689a9a91d0 and compiler doesn't like changes from Bug 1139552

[Nicholas McAnespy]

54 minutes ago, roytam1 said:

now there is a problem when merging 0b23a2783d03b3f5fe404544db3043689a9a91d0 and compiler doesn't like changes from Bug 1139552

In js/src/gc/Heap.h, #include "mozilla/TypedEnum.h", and then check if you can get away with using MOZ_BEGIN_ENUM_CLASS(AllocKind, uint8_t) in place of enum class AllocKind : uint8_t {. Also, replace } with MOZ_END_ENUM_CLASS(AllocKind). I do not guarantee that will work, but it typically will. If it doesn't, you'll need to use enum : uint8_t {. What error message are you getting with bug 1139552?

[roytam1]

5 hours ago, Nicholas McAnespy said:

In js/src/gc/Heap.h, #include "mozilla/TypedEnum.h", and then check if you can get away with using MOZ_BEGIN_ENUM_CLASS(AllocKind, uint8_t) in place of enum class AllocKind : uint8_t {. Also, replace } with MOZ_END_ENUM_CLASS(AllocKind). I do not guarantee that will work, but it typically will. If it doesn't, you'll need to use enum : uint8_t {. What error message are you getting with bug 1139552?

not about this, but in https://github.com/roytam1/palemoon27/commit/0b23a2783d03b3f5fe404544db3043689a9a91d0#diff-b47b303bd98eb8064d494a10619a2ddb211dc18156bdca90862f5c8eda97fe26R67

VC2010 needs non-typed-enum here(jsgc.h)

Edited July 9 by roytam1

[Nicholas McAnespy]

@roytam1
Before I do any more work on Visual C++ 2008 SP1 compatibility, should I use the pm2796-vc2012 branch, or the 27100-vc2010 branch? If it's possible to use Git 2.10.0 in Windows XP SP3, and if you have an excessive amount of patience, I would like it if you could help me use it.

[roytam1]

2 hours ago, Nicholas McAnespy said:

@roytam1
Before I do any more work on Visual C++ 2008 SP1 compatibility, should I use the pm2796-vc2012 branch, or the 27100-vc2010 branch? If it's possible to use Git 2.10.0 in Windows XP SP3, and if you have an excessive amount of patience, I would like it if you could help me use it.

pm2796-vc2012 ends after dropping in fx38vc10pm changes, while pm27100-vc2010 tries to merge newer changes before changing version to 27.10.0

git for XP should still work with current github repo.

[Nicholas McAnespy]

On 7/11/2024 at 1:10 AM, roytam1 said:

pm2796-vc2012 ends after dropping in fx38vc10pm changes, while pm27100-vc2010 tries to merge newer changes before changing version to 27.10.0

git for XP should still work with current github repo.

After a day of trying out some git commands, I realized Git 2.10.0 does not support Codeberg due to a problem with the SSL certificate. I finally logged back in to my GitHub account, and also realized I can download whatever I want from Git 2.10.0, but I can't upload anything from there because password authentication is no longer supported on GitHub. What git command do you recommend using to port palemoon27-classic, and eventually palemoon27-master commits to palemoon27-pm27100-vc2010?

[roytam1]

3 hours ago, Nicholas McAnespy said:

After a day of trying out some git commands, I realized Git 2.10.0 does not support Codeberg due to a problem with the SSL certificate. I finally logged back in to my GitHub account, and also realized I can download whatever I want from Git 2.10.0, but I can't upload anything from there because password authentication is no longer supported on GitHub. What git command do you recommend using to port palemoon27-classic, and eventually palemoon27-master commits to palemoon27-pm27100-vc2010?

I think you may still able to use non-HTTPS for uploading.

for example, one of my local repo still has this in git config:

[remote "origin"]
	url = git@github.com:roytam1/rtoss.git
	fetch = +refs/heads/*:refs/remotes/origin/*

and I can still able to `git push` from this repo.

[Nicholas McAnespy]

30 minutes ago, roytam1 said:

I think you may still able to use non-HTTPS for uploading.

for example, one of my local repo still has this in git config:

[remote "origin"]
	url = git@github.com:roytam1/rtoss.git
	fetch = +refs/heads/*:refs/remotes/origin/*

and I can still able to `git push` from this repo.

My Git commands presently are "mkdir palemoon27-27100-VC2010-WIP" "cd /F/palemoon27-27100-VC2010-WIP" "git clone "https://github.com/ClassicNick/palemoon27.git" and Ex. "git cherry-pick 593d1c0". Basically, my method is cherry picking all commits from newer branches. That way, I don't need to worry as much about git conflicts. As for SSH, I don't know how to add an SSH key. Now that I can cherry-pick commits, after how many changes should I upload the source code?

[roytam1]

7 minutes ago, Nicholas McAnespy said:

My Git commands presently are "mkdir palemoon27-27100-VC2010-WIP" "cd /F/palemoon27-27100-VC2010-WIP" "git clone "https://github.com/ClassicNick/palemoon27.git" and Ex. "git cherry-pick 593d1c0". Basically, my method is cherry picking all commits from newer branches. That way, I don't need to worry as much about git conflicts. As for SSH, I don't know how to add an SSH key. Now that I can cherry-pick commits, after how many changes should I upload the source code?

https://docs.github.com/en/authentication/connecting-to-github-with-ssh

and of course you can always push your changes in anytime. I normally push changes after some successful `git merge`

[Nicholas McAnespy]

@roytam1 Now that I'm cherry picking commits from our palemoon27 repositories that are dated ~September 2019, I notice commit partial hash d918e4f (9/17/2019) apparently contains e10s code that you didn't like at the time (Accusation caused by f25cb74, which was dated 9/20/2019). Should I try cherry picking d918e4f, or should I move on without it? Also, I decided to read some comments on your 1st browser builds thread, and you said the Ryzen 7 3700X with your SSD caused build times to be 1/3 of what they were with your previous hardware. What were the specs of the previous computer you did your browser builds on?

Edited July 18 by Nicholas McAnespy