Jump to content

[BUG+FIX] fileVersionGreaterThan can fail on minor versions


Recommended Posts

Fix

In registry_dos.js replace


function fileVersionGreaterThan(fileVersion1,fileVersion2)
{
position="registry_dos.js";
whatfunc="fileVersionGreaterThan()";

var split1, split2;

split1=fileVersion1.toString().split(".");
split2=fileVersion2.toString().split(".");

for (var i=0; i<split1.length; i++)
{
var split2item=parseInt(split2[i]);
if ((parseInt(split1[i]) > (isNaN(split2item) ? 0 : split2item)))
return true;
}

return false;
}

with


function fileVersionGreaterThan(fileVersion1,fileVersion2)
{
position="registry_dos.js";
whatfunc="fileVersionGreaterThan()";

var split1 = fileVersion1.toString().split("."),
split2 = fileVersion2.toString().split(".");

for (var i=0; i<split1.length; i++)
{
var split1int = parseInt(split1[i]),
split2int=parseInt(split2[i]);
if (!isNaN(split2int) && (split1int < split2int))
return false;
else if (split1int > (isNaN(split2int) ? 0 : split2int))
return true;
}

return false;
}

Link to comment
Share on other sites


Guest
This topic is now closed to further replies.
  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...