%cdrom% path

[mritter]

First: midiboy, fixed the bug with

cddrv = WshShell.RegRead("HKLM\\Software\\Microsoft\\Windows\\CurrentVersion\\Setup\\SourcePath") + "\\";

Now does a proper Vista check as suggested a month ago. I never updated the code. My bad.

Second: I, too, agree with zorphnog that the code for finding cddrv (%cdrom%) sucks. Right now it does 3 checks for CD, only the first is really reliable. So, take out other 2? (core.js)

Then, when you have a %cdrom%\\blah.exe in a your config, if WPI was not started from a CD/DVD cddrv is blank. Install fails. What about:

if (cddrv=="")
   cddrv=wpipath;

This will at least give it a better chance in working.

Yes? No? Keep it as is?

[Kelsenellenelvian]

Yes!

[Nobby Barnes]

I already 'handle' this.

for EVERY install action, I create a 'stand-alone' batch file with the install commands.

This gives me portability from stand-alone DVD WPI installs to Domain scripted deploys..

I add the following code at the head of every batch..

set cdrom=""
FOR %%i IN (D E F G H I J K L M N O P Q R S T U V W X Y Z) DO IF EXIST %%i:\CD.txt SET CDROM=%%i:
rem pause
if %cdrom%=="" set cdrom=C:\Builds\Win_Base_SW_install

If I'm running from CD, then I create CD.txt in the root of the disk.

That way I can 'pretest' my install scripts directly on my build system out of the builds folder..

Java just causes 'out of memory' errors in my brain.!