Any errors in this batch script?

[absclaw]

just wished if any1 could find some possible errors with this script:

@ECHO OFF

TITLE IMPORTANT SYSTEM TASKS

COLOR 03

ECHO.

ECHO REGISTERING SHIMGVW.DLL

regsvr32 /i /s "%WinDir%\system32\shimgvw.dll"

ECHO.

ECHO RUNNING THE XP SP3 GENUINE ADVANTAGE TOOL

START "" /I /WAIT "%systemdrive%\install\installer.bat"

ECHO.

ECHO ACTIVATING WINRAR

COPY "%systemdrive%\install\rareg.key" "%systemdrive%\Program Files\WinRAR" /V /Y 1>nul

ECHO.

ECHO Deleting default Internet Explorer Favorite Links...

RMDIR /S /Q "%UserProfile%\Favorites\Links"

RMDIR /S /Q "%UserProfile%\Favorites\Microsoft Websites"

ECHO.

ECHO Adding new Internet Explorer Favorite Links...

START "" /I /WAIT "%systemdrive%\install\IE Favorite Links.bat"

ECHO.

ECHO Installing: Windows XP Security Update for CAPICOM (KB931906) v2102

ECHO Please wait...

START "" /I /WAIT "%SYSTEMDRIVE%\install\Windows XP Security Update for CAPICOM (KB931906) v2102.exe" /q

ECHO.

ECHO Installing: Foxit Reader v3.0 Build 1506

ECHO Please wait...

START "" /I /WAIT "%SYSTEMDRIVE%\install\Foxit Reader v3.0 Build 1506.exe" /i

ECHO.

ECHO Iconising Taskbar

START "" /B /WAIT "%systemdrive%\install\Install.reg" /Y

ECHO.

ECHO Cleaning up temporary setup files

RMDIR /S /Q "%SYSTEMDRIVE%\install"

ECHO.

ECHO FINISHED---FINISHED---FINISHED

ECHO.

PAUSE

EXIT

hope any1 could help me out with this .cmd file as I had encountered sum problems with it....

Edited December 25, 2009 by absclaw

[Martin H]

A quick glance just reveals one error in :

ECHO Iconising Taskbar
START "" /B /WAIT "%systemdrive%\install\Install.reg" /Y

You need 'regedit /s' to merge a regfile silently...

Other than that, then for nitpicking:

'/y' parameter is redundant in the 'copy' command when run from a NT command script.

'/i' parameter is redundant in your 'regsvr32' commands.

.cmd is more appropriate than .bat on NT systems.

'rd' is the same as the older 'rmdir'.

lastly, maybe i'm wrong here, and just ignore this, but in my personal experience, then 'start "" /wait' dosen't make a difference, as the NT command interpreter by default waits for completion, and in cases where it dosen't, then that command don't make a difference, since it's because a program runs another process...

[absclaw]

thnx a lot sir, now I've understood the function of regedit/s and thnx again for rectifying other errors as well.It seems obvious now why it wasn't working.

[urie]

Just another point if the winrar rareg.key is in the same folder as winrar installer it will self register

[absclaw]

thnx for the advice urie..will try it out for sure.