Jump to content
MSFN is made available via donations, subscriptions and advertising revenue. The use of ad-blocking software hurts the site. Please disable ad-blocking software or set an exception for MSFN. ×

5.2 bugs and problems


Recommended Posts

Open installer.js and look at this line:

Pause(0,100);																//wait for the new document to be fully loaded

Try increasing that value and see if the error still appears.

Yep, once again sadicq is right:

I've only tested the installer from HDD and found the 100ms value to be enough, but did not think about you guys still burning disks :blushing:

You may want to use sadicq's fix:

while (window.document.readyState != 'complete')
Pause(0,100); //wait for the new document to be fully loaded

Edited by Djé
Link to comment
Share on other sites


Ok... I know this sounds stupid, but I spent 2 hours on this bug ...

Open patchFile.js in notepad and replace

patchLine(wpipath + "Themes\\" + Theme + "\\wpi.htm", /class="txt"/ig, 'class="opText"');

with

//patchLine(wpipath + "Themes\\" + Theme + "\\wpi.htm", /class="txt"/ig, 'class="opText"');

Somebody forgot to comment it out ....

Attention: Apply this fix on a clear WPI as the line that is not commented has already modified your WPI if you ran it from hdd.

The problem showed up only when you were running WPI from CD because it was read-only and the script could not modify the files ....

Note that the line you are commenting is just an example and it is not needed by WPI. Actually it's doing just the opposite.

One More, sadicq :thumbup !

It looks like the file patcher is not yet used to update the themes. So it should not even be called from wpi.hta.

Anyway, that example function call was meant for 5.1 and has no reason to be anymore.

Further, since there is no more class="txt" in wpi.htm, it has no effect at all! Only triggering strange bugs!

Because of this, you don't even need to "Apply this fix on a clear WPI". Just comment the line out as showed by sadicq. In any case.

By the way, the opText class, which exists in wpi.htm since at least 5.0, never had any definition in wpi.css!

So it seems it's useless altogether as nobody noticed it! One more simplification to implement in the themes!

Link to comment
Share on other sites

I have got this advice from MRitter yesterday:

First thing to try is this in WPI.hta, line 43

fullpath = fullpath.replace("file:///","").replace(/\//g,"\\\\");

Take out 1 of the slashes after file:/// Try with only 2.

But thats already done by himself I think before going public with 5.2, so that is no solution for this problem.

Actually, this way you're breaking the process that finds the command line parameters:

Strangely, document.location features these 3 /s: "file:///".

You can check it by yourself by inserting this line in the code and watch the result:

alert(document.location);

So, as the current 5.2 download only features 2 /s, there's a bug there too.

BUT this should NOT trigger any other bug than not being able to use command line parameters anymore.

More specifically, this is not related to the bugs discussed above.

Link to comment
Share on other sites

Hello

Sorry for my english i'm French

I tri WPI 5.2 but i cannot exit (only way is Taskmanager --> kill).

Can you help me ?

Salut Fred ;)

If you problem occurs during installation, one possibility is that you may have a program launched by WPI that is still running (the last uncheck one in the installer).

WPI is waiting for it to terminate before closing itself.

Link to comment
Share on other sites

Is it possible for all other people that read this bug topic, that all replacement are set in one message so it's clear wat we must adjust.

I should say Kel's announcement of this topic should keep the fixes updated, or one of you sadicq or Djé .

Because now there are more bugs been fixed.

Just to be clear for everyone.

Thanks :thumbup

Edited by Pliek
Link to comment
Share on other sites

Is it possible for all other people that read this bug topic, that all replacement are set in one message so it's clear wat we must adjust.

I should say Kel's announcement of this topic should keep the fixes updated, or one of you sadicq or Djé .

Because now there are more bugs been fixed.

Just to be clear for everyone.

Thanks :thumbup

Very good idea. I'd also say that this is Kel's job ;) .

But since you've posted (and experienced) some of them, you may help him a lot by summarizing what is fixed for you, and help us debugging by making another list of what remains to be fixed (again, only for your problems is enough).

Link to comment
Share on other sites

Ok, here's the solution (the post before was just to determine the source of the problem, but I'm pretty sure that that was the problem).

In installer.js, replace

Pause(0,100);																//wait for the new document to be fully loaded

with

while (window.document.readyState != 'complete')
Pause(0,100); //wait for the new document to be fully loaded

And this will work every time.

Yeah sadicq, that solved the problem. But I do not have to post this, because we did not expect anything else, or did we? :P

So if the errors of Pilek are solved, what about releasing WPI 5.2.1, because with WPI 5.2 there is no way to make an install from Disc drive. :)

Link to comment
Share on other sites

So, as the current 5.2 download only features 2 /s, there's a bug there too.

BUT this should NOT trigger any other bug than not being able to use command line parameters anymore.

More specifically, this is not related to the bugs discussed above.

Already talked to mritter about that problem.

Bugs reported so far

1. Progress bar wrong id. Link Fix [sidenote: you may also remove that line ...]

2. Uncommented line for theme update. Link Fix [sidenote: the file patcher should be modified because it generates those errors when it is run from a read-only media]

3. Not a bug, but an enhancement. Link & fix

4. Pause time issue. Link Fix

5. Command line parameters issue. Link Fix sent to mritter.

6. A bug ... Link No fix yet [i couldn't reproduce it yet].

7. Installation slowed down. Link No fix yet [i couldn't reproduce it yet].

I hope these are all the bugs that were reported so far.

Thanks Dynaletik and Pliek for the bug reports.

Edited by sadicq
Link to comment
Share on other sites

6. A bug ... Link No fix yet [i couldn't reproduce it yet].

The bug most probably comes from this line:

var winntinf=fso.OpenTextFile(sysdir + "\\$winnt$.inf", 1);

on line 126 of generate.js.

@wixfigura, can you run a test after inserting the following line just before the one mentioned above:

alert(sysdir + "\\$winnt$.inf\n" + (FileExists(sysdir + "\\$winnt$.inf") ? 'Exists' : 'ABSENT'));

And tell us what the message box says?

Can you also tell us if you have a $winnt$.inf in your system32 directory?

And if not, if you know why you haven't?

Link to comment
Share on other sites

I have a problem with the new WPI 5.x.

I guess it's a known problem but can't find a solution anywhere.

In my config.js there are allot of 7z sfx installers.

After they are extracted they start installing on their own.

The problem is that this new WPI doesn't wait for them to install....

It proceeds with the next item therefore not installing everything properly.

Is there a fix or something for this?

config.js

Link to comment
Share on other sites

Oke I'm back, I have been testing and the results are good...

I'll tell exactly what I have done, accourding to the errors WPI gave me by starting .

I have modified these files The numbers are from sadicq list of fixes: (Thanks for the list sadicq)

2. Uncommented line for theme update.

Link Fix

Open patchFile.js and replace

patchLine(wpipath + "Themes\\" + Theme + "\\wpi.htm", /class="txt"/ig, 'class="opText"');

with

//patchLine(wpipath + "Themes\\" + Theme + "\\wpi.htm", /class="txt"/ig, 'class="opText"');

3. Not a bug, but an enhancement.

Link & fix

4. Pause time issue.

Link Fix

In installer.js, replace

Pause(0,100);																//wait for the new document to be fully loaded

with

while (window.document.readyState != 'complete')
Pause(0,100); //wait for the new document to be fully loaded

5. Launching from a .cmd file and start cd/dvd problem: I've got this by mail from mritter today (it worked).

In wpi.hta line 43 replace

fullpath = fullpath.replace("file://","").replace(/\//g,"\\\\");

with

fullpath = fullpath.replace("file:///","").replace(/\//g,"\\ <file:///> ");

See if that cures the launching from cd/dvd problem with a .cmd file (it worked for me)..

7. Bug that slows down the install time is related with these other ones (don't no witch one).

All 192 programs installed perfect, and the installation time of these 192 programs was again 32 minutes (like it always was, so the "bug" that gave 20 minutes extra longer install. time is also solved).

And at last one little thing took place, the time for showing up my rebootscreen (called from a .cmd file) took over 90 seconds to appear. To be specific, my desktop got cleaned 90 seconds after the installer screen dissapeard, and almost right after that... the shutdown screen poped up.

That .cmd file looks like this.

@ECHO OFF
REM Hide this command window.
%systemroot%\system32\cmdow.exe @ /hid

REM Example, how to look for CDROM-drive. Must have win51ip.SP2 at the root of the CD.
for %%i in (C D E F G H I J K L M N O P Q R S T U V W X Y Z) do if exist %%i:\win51ip.SP2 set CDROM=%%i:
echo Found CD-Rom as drive %CDROM%

set wpipath=%cdrom%\WPI

start /wait %cdrom%\WPI\WPI.hta

!!!!!!!!! 90 seconds slowing down between these too commands !!!!!!!!!!

DEL "%AllUsersProfile%\Bureaublad\*.lnk"
DEL /s/q "%userprofile%\Bureaublad\*.lnk"

DEL "%systemdrive%\*.log"

RD /S /Q %systemdrive%\Install\

net user aspnet /delete

REM Reset Windows Security Center.
SET PP=%systemroot%\system32\WPI\
SET KEY=HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\RunOnceEx
REG ADD %KEY% /V TITLE /D "Resetten van het Beveiligingscentrum" /f
REG ADD %KEY%\001 /VE /D "Reset Windows Security Center" /f
REG ADD %KEY%\001 /V 1 /D "%PP%WinMgmt.cmd" /f

REM Herstarten van de PC binnen 30 seconden...
shutdown.exe -r -f -t 30 -c "Windows zal over 30 seconden worden herstart."

EXIT

That is the onely thing in my case that needs to be looked after.

I hope i've given all the right information, if you guys need more ...let me know.

Edited by Pliek
Link to comment
Share on other sites

I still get this error.

*just copied config.js from my old WPI lite 1.2

errrre3.th.jpg

Seems like compatibility issue. seems like I have to manually input every program again. could you save me from hours of typing Kel? ;)

Edited by larciel
Link to comment
Share on other sites

I have all the known fixes worked in to the latest 5.3 beta. Sadly, when I was testing with other people's config files I found a few more errors not yet reported. Mostly cosmetic but still a bug.

Link to comment
Share on other sites

I have all the known fixes worked in to the latest 5.3 beta. Sadly, when I was testing with other people's config files I found a few more errors not yet reported. Mostly cosmetic but still a bug.

so you have fixed the error I'm having? if not, do you need my config.js ? I'll upload it if you need it to fix the issue.

thanks in adv

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share

  • Recently Browsing   0 members

    • No registered users viewing this page.

×
×
  • Create New...